chore: adapt to decide := false in simp#78
Merged
JLimperg merged 1 commit intoleanprover-community:masterfrom Oct 26, 2023
Merged
chore: adapt to decide := false in simp#78JLimperg merged 1 commit intoleanprover-community:masterfrom
decide := false in simp#78JLimperg merged 1 commit intoleanprover-community:masterfrom
Conversation
3 tasks
Collaborator
|
I'd prefer to match stock
Does |
3d1eb39 to
e6d2c12
Compare
Contributor
Author
|
@JLimperg It's easy to fix it on the mathlib side, I just mistakenly thought |
decide := false in simp
e6d2c12 to
773aaa0
Compare
Collaborator
|
Great, thanks! I'll merge when CI is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Future-proofing for leanprover/lean4#2722. A comment on
SimpConfigis missing but I didn't exactly know what to write.