Skip to content

chore: upstream have/suffices/let without :=#239

Closed
kim-em wants to merge 1 commit intoleanprover-community:mainfrom
kim-em:have
Closed

chore: upstream have/suffices/let without :=#239
kim-em wants to merge 1 commit intoleanprover-community:mainfrom
kim-em:have

Conversation

@kim-em
Copy link
Copy Markdown
Collaborator

@kim-em kim-em commented Sep 5, 2023

No description provided.

@kim-em kim-em added the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Sep 5, 2023
@digama0
Copy link
Copy Markdown
Member

digama0 commented Sep 5, 2023

I'm dubious about this. Overloading have causes some problems for parsing, and so this would be better placed in lean core where it can actually cooperate with the existing tactic. Moreover, we already have have := by ... and have := ?_ for making have subgoals, so it's not obvious that this is actually needed and not just a lean3-ism.

@kim-em
Copy link
Copy Markdown
Collaborator Author

kim-em commented Sep 5, 2023

Indeed. I actually wanted to upstream replace, but the Mathlib implementation imported this file so I blindly did that first. 🤦‍♀️

If the diff isn't too bad, would you be happy with deleting these tactics from Mathlib?

@kim-em
Copy link
Copy Markdown
Collaborator Author

kim-em commented Sep 5, 2023

Okay, I did some of this at leanprover-community/mathlib4#6964, and I absolutely agree these tactics should be removed rather than upstreamed. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review This PR is ready for review; the author thinks it is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants