Skip to content

feat: make Lean.Grind.Preorder a mixin#9885

Merged
kim-em merged 6 commits intomasterfrom
preorder_mixin
Aug 13, 2025
Merged

feat: make Lean.Grind.Preorder a mixin#9885
kim-em merged 6 commits intomasterfrom
preorder_mixin

Conversation

@kim-em
Copy link
Copy Markdown
Collaborator

@kim-em kim-em commented Aug 13, 2025

This PR is initially motivated by noticing Lean.Grind.Preorder.toLE appearing in long Mathlib typeclass searches; this change will prevent these searches. These changes are also helpful preparation for potentially dropping the custom Lean.Grind.* typeclasses, and unifying with the new typeclasses introduced in #9729.

@kim-em kim-em requested a review from leodemoura as a code owner August 13, 2025 03:32
@kim-em kim-em added the changelog-language Language features and metaprograms label Aug 13, 2025
@kim-em
Copy link
Copy Markdown
Collaborator Author

kim-em commented Aug 13, 2025

(This will break Mathlib; the fixes should be easy so I'll do those when this lands in nightly-testing.)

@kim-em kim-em added this pull request to the merge queue Aug 13, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 13, 2025
@ghost
Copy link
Copy Markdown

ghost commented Aug 13, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 21fa5d10f437a05a1af001396d2748b92f151d50 --onto e0fcaf5e7ddab2fcab51be8c403446d84a8a0d45. You can force Mathlib CI using the force-mathlib-ci label. (2025-08-13 05:22:55)

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 21fa5d10f437a05a1af001396d2748b92f151d50 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-08-13 05:22:56)

Merged via the queue into master with commit 93e0ebf Aug 13, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-language Language features and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants