fix: fix FieldInfo for structure instance notation#7745
Merged
kmill merged 2 commits intoleanprover:masterfrom Mar 31, 2025
Merged
fix: fix FieldInfo for structure instance notation#7745kmill merged 2 commits intoleanprover:masterfrom
kmill merged 2 commits intoleanprover:masterfrom
Conversation
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an oversight in #7717, and now fields get a FieldInfo node with the correct projection function.
Note that for copied fields "go to definition" still does not go anywhere, since copied projection function has no declaration range. We probably should make such fields instead go to the origin projection function.