feat: dotParam widget to control dot notation#6267
Draft
kmill wants to merge 1 commit intoleanprover:masterfrom
Draft
feat: dotParam widget to control dot notation#6267kmill wants to merge 1 commit intoleanprover:masterfrom
dotParam widget to control dot notation#6267kmill wants to merge 1 commit intoleanprover:masterfrom
Conversation
This PR introduces the `dotParam` marker to indicate which parameter should be used for generalized field notation ("dot notation"). Example:
```
class A (α : Type _) where
a : α → Nat
def A.get {α : Type _} [A α] (self : dotParam α) : Nat := a self
structure B where
b : Nat
instance : A B := ⟨B.b⟩
namespace B
export A (get)
end B
#check fun (b : B) => b.get
-- b.get : Nat
```
The pretty printing code is modified to support the `export`-resolved dot notation introduced in leanprover#6189.
Closes leanprover#1629, closes leanprover#5482
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
dotParammarker to indicate which parameter should be used for generalized field notation ("dot notation"). If a function has adotParamparameter, then this will be used instead of any other argument. Example application:The pretty printing code is modified to support the
export-resolved dot notation introduced in #6189.Closes #1629, closes #5482