perf: improve heuristic at isDefEq#3837
Merged
leodemoura merged 2 commits intomasterfrom Apr 22, 2024
Merged
Conversation
Collaborator
Author
|
Curiously, deleting and reduces the heartbeat count to around 80,000. |
Collaborator
Author
|
These are the outputs of (i.e. the step that is timing out) both before and after #3807. Be warned that |
|
Mathlib CI status (docs):
|
6a5bde8 to
c4d2ff3
Compare
tryHeuristic at ExprDefEq.lean
tryHeuristic at ExprDefEq.leanisDefEq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test case containing a minimization of a Mathlib slowdown from #3807, and a patch to isDefEq to fix the slowdown.
Prior to #3807, the declaration
exists_algHom_adjoin_of_splits'''at the end of the file would take around 16,000 heartbeats. After #3807 it took around 210,000 heartbeats.