Conversation
|
Thanks for your contribution! Please make sure to follow our Commit Convention. |
|
But |
|
Oh dear, very sorry to have caused this nonetheless! If I PR core or std4 in the future, I'll be sure to build Mathlib to make sure that only expected breakages occur. I look forward to the automatically posted build reports, however, as a full Mathlib build is quite a bit for my laptop to handle! :) (Though I suppose I could convince CI to do it on a branch/PR.) I'll start investigating this tomorrow. Will the PR release for #2435 still work? (I've briefly tried Also: can/should #2435 be reopened, or should I make a new one (possibly with a new branch)? |
|
Couldn't resist taking a peek: what's happening (at least in the first example) is that |
Ah, okay, indeed that makes it harder to catch in Lean itself, and I feel less bad about this. With this toolchain many of the uses of |
Reverts #2435, which thoroughly broke Mathlib, because
changestatements are now duplicating goals. See the build output at https://github.com/leanprover-community/mathlib4/actions/runs/6021210761/job/16333708649?pr=6863.I am still working on automatically posting reports on Mathlib builds back to Lean PRs, which would have caught this, but not there yet. What we do have is automatically generated toolchains for releases, e.g. as
lean/leanprover-pr-releases:pr-release-XXXX, so at least it is already possible to manually test.No fault of @thorimur's, but this does demonstrate how our testing library still falls far short. This scenario of
changebreaking so badly should have been caught well before Mathlib.@thorimur, I am going to revert your PR for now, and leave it to you to reconsider how to do this. It may be best that we write some proper tests for
changefirst!