feat: eta_reduce_fun% in cdot parser#2263
Open
digama0 wants to merge 3 commits intoleanprover:masterfrom
Open
Conversation
Collaborator
Author
|
Hm, this still isn't working, and I have another reimplementation which also isn't working. I know how to make a version which sometimes fails to eta-reduce but doesn't break anything, but I think I will need to ask for help making this work properly, I don't think I fully understand how to do this with postponement. cc: @leodemoura |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This and #2267 are two implementations of the same feature, merge only one.
This modifies the desugaring for the cdot parser to apply eta-reduction to the resulting term if possible. So
(· + ·)elaborates toHAdd.hAddinstead offun x y => HAdd.hAdd x y.This is complicated by the fact that metavariables generally capture all variables in scope, meaning that
(· + ·)of unknown type elaborates to something likefun x y => @HAdd.hAdd (?m1 x y) (?m2 x y) x y, which is not an eta redex. To reliably eta reduce the expression we therefore have to wait for all the mvars to be solved, but we also can't postpone because the body of the lambda might itself be postponing, and the combination seems to make some existing test cases fail. So instead we register a secondaryeta_reduce_delayed%expression which waits for the body to be resolved with no mvars, and then does the eta reduction.