Conversation
Member
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 09cde79. |
Contributor
|
Thanks Gabriel! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2074 Structure eta is for TC instances is required to see that subobject projections are defeq with constructor applications. These diamonds occur with fine-grained instance hierarchies like the algebraic hierarchy in mathlib, and they need to be defeq during TC search if the instances occur as a parameter to another type class.
Structure eta was disabled as a quick fix for the issue reported at https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/.60constructor.60.20and.20.60Applicative.60/near/279984801
However the example in that issue had two non-defeq
Functorinstances. We do not support non-defeq instance diamonds in general and lots of other modules will break with them. For example simp lemmas won't fire (because the instances don't match), the elaborator will error out, etc. Therefore I have decided to change the example from that issue to remove the non-defeq diamond, and reenabled structure eta during TC search.