fix: synthesize tc instances before propagating expected type#1893
Merged
leodemoura merged 2 commits intoleanprover:masterfrom Nov 29, 2022
Merged
fix: synthesize tc instances before propagating expected type#1893leodemoura merged 2 commits intoleanprover:masterfrom
leodemoura merged 2 commits intoleanprover:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1892.
The error in #1892 is caused by propagating the expected type before the instance for
LE (OrderDual α)has been synthesized. Before TC synthesis, the unifier can still assign the metavariable for the instance.This PR changes the application elaborator to try TC synthesis before propagating the expected type (we already do it before applying function coercions).