Fix numpy size() and add test #1780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Ready. |
Contributor
|
Perfect. Since we are doing this, can you please also add in a test for some unsigned integer array, say Also let's rebase on top of the latest master, just to make sure. |
33afbcc to
5329920
Compare
Collaborator
Author
|
Ready. |
certik
approved these changes
May 11, 2023
Contributor
certik
left a comment
There was a problem hiding this comment.
I think this looks great, thanks!
certik
reviewed
May 11, 2023
Comment on lines
+5
to
+6
| x: i32[4, 5, 2] = empty([4, 5, 2]) | ||
| y: f64[24, 100, 2, 5] = empty([24, 100, 2, 5]) |
Contributor
There was a problem hiding this comment.
I noticed one problem here, but I created a dedicated issue for this: #1790, as we need to test that LPython reports an error here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #1777 (review).