Skip to content

Conversation

@Smit-create
Copy link
Collaborator

Fixes #1601

@Smit-create Smit-create requested review from certik and czgdp1807 March 22, 2023 07:30
Copy link
Collaborator

@czgdp1807 czgdp1807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we testing this at CI?

Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we are not testing this at the CI, but I think it's fine to merge as is.

@Smit-create
Copy link
Collaborator Author

Thanks @certik @czgdp1807. Presently, we don't, either of llvm or c backend using this on CI, but we should eventually. I'll try to add a small test in CI to see if it's fine.

@Smit-create Smit-create marked this pull request as ready for review March 23, 2023 05:15
@Smit-create Smit-create requested review from certik and czgdp1807 March 23, 2023 11:04
@Smit-create Smit-create added enhancement New feature or request c Label for C language related changes labels Mar 23, 2023
Copy link
Collaborator

@czgdp1807 czgdp1807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The small test makes sense. Another way to test is to use --backend=c for some tests in integration_tests/CMakeLists.txt.

@certik certik merged commit 1a93c68 into lcompilers:main Mar 23, 2023
@Smit-create Smit-create deleted the c_back branch March 24, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c Label for C language related changes enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Directly compile using --backend=c

3 participants