Skip to content

Feature sliding timeline#40

Merged
lcallarec merged 5 commits intolcallarec:masterfrom
Robert-Ordis:feature-sliding-timeline
Jan 3, 2023
Merged

Feature sliding timeline#40
lcallarec merged 5 commits intolcallarec:masterfrom
Robert-Ordis:feature-sliding-timeline

Conversation

@Robert-Ordis
Copy link
Contributor

Makes x-axis timeline sliding(scrollable) with the serie.

  • Currently, I'm thinking how to test this. (Calculate the pos of gridline and pick its color up ?>

 - If true, then grid of time and its timestamp are scrolling with chart.
 - Each grid will have a fixed timestamp value(timestamp - timestamp % tick_interval)
@Robert-Ordis
Copy link
Contributor Author

Robert-Ordis commented Dec 9, 2022

Is there any idea what I should do to ? xo

 - consume the positions of 2nd grid from the right edge, and pick their color up.
@Robert-Ordis
Copy link
Contributor Author

@lcallarec
I tried to write the test of this.
Is this right ?

@Robert-Ordis Robert-Ordis changed the title [WIP]Feature sliding timeline Feature sliding timeline Dec 12, 2022
@lcallarec
Copy link
Owner

Sorry, was in long holydays :)

Outside the small typo in the documentation, looks good !

@Robert-Ordis
Copy link
Contributor Author

Fixed it. xo

@lcallarec
Copy link
Owner

Thanks @Robert-Ordis !

@lcallarec lcallarec merged commit fd41272 into lcallarec:master Jan 3, 2023
@Robert-Ordis
Copy link
Contributor Author

Thanks @Robert-Ordis !

Thx 4 your merging.
I'll prepare for the next PR.
Happy New Year!

@Robert-Ordis Robert-Ordis deleted the feature-sliding-timeline branch January 5, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants