Merged
Conversation
- Causes memory leak after removing LiveChart.Chart from Widget.
- Test for function Serie.remove_serie(serie) - Proof of disconnecting serie.value_add: Check if bounds is updated or not.
- Chart.remove_serie(serie)
- Chart.remove_all_series();
- Basically same as /LiveChart/Series/remove_serie#disconnect_serie.value_add
…rdis/live-chart into feature-removable-serie
- NOTE: Stopping auto-refresh is necessary to invoke destroy/Destructor.
lcallarec
reviewed
Dec 7, 2022
lcallarec
reviewed
Dec 7, 2022
lcallarec
reviewed
Dec 7, 2022
lcallarec
reviewed
Dec 7, 2022
Contributor
|
This looks cool! |
lcallarec
reviewed
Dec 7, 2022
| assert(chart.config.y_axis.get_bounds().upper == 200.0); | ||
| try{ | ||
| series.get_by_name("Test 1"); | ||
| assert(false); |
Owner
There was a problem hiding this comment.
Not blocking at all : another option would be to use assert_not_reached(), technically equivalent, but IMHO, it's sementically a bit better :)
Owner
|
@Robert-Ordis : thanks for this one ! Outside my comments, looks good to me ! |
- register(serie): Use Series.series.contains to check if the serie is already registered.
Contributor
Author
|
Thank you for your revieweing. If not, then, I'll go to prepare the next PR. |
Owner
|
Good to merge ! Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has changes about removing serie/chart.
But, stopping automatic-rendering is not able while removing from parent automatically.
So, I add how to remove LiveChart.Chart from Widget as "CAUTION" section.