Conversation
- Config.time.current = [int64 val] to specify the time. - Default unit of time is "m" (means [msec]) - Drawbacks: Never fits to Serie.add(double value) when unit is "s"[sec] or "u" [usec]
- tick_interval is [sec] -> then, config.time.conv_sec should be used.(was conv_msec)
- If true, time on x_grid is shown to fractional part.
... ... and I forgot to convert tab to space4.
- Shows speed ratio(*sec) while scrolling. - If play_ratio = 0.0, then it indicates to pause.
|
@lcallarec |
|
I'm glad to see this PR, kudos @Robert-Ordis ^^ Technically, it looks good. I will test very soon this feature on a real environment. If everything is ok on a functional point of view, outside my small comment, I will merge this PR. If you got time to improve this code in the future, I'll suggest you to :
chart.config.time.now();
Anyway, that not blocking at all. Thank you ! |
|
Dear, @lcallarec I'm so happy for your evaluation...lol Yes, your pointing about abstraction is right. OK, I'll try to make a testcode for it. thank you so much. |
- It caused confusion to me...
- Can keep running until 290k years elapsed from 1970-01-01 00:00:00(utc).
|
Excuse me to additional commit. Inside story: On my app(https://github.com/Robert-Ordis/omni-plotter), I'm thinking that treating time in microsec might be needed in the future. |
|
I just tested your PR, it works like a charm :) Please fix the documenation issue I noticed earlier and your PR will be merged (up to you to improve the basecode according to my previous recommendations in another PR later) |
- Adopt to other time range.
- Fix the mistake on "Seeking on the timeline." - Add "Specify the range of the timeline."
|
I pushed documentation mod (mainly related to dropped property and config.time.set_range)
Please tell me what the issue you noticed is. your suggestions in this PR? |
|
The (small) documentation issue is here : https://github.com/lcallarec/live-chart/pull/38/files/0cd13fdd75f63d05e8cad992b1b25fcd02aaa72c#diff-3a1bd79644f8f66a114a45997f889dcba1ca809b0bb65865d4d7117ddc3e023fR32 As a rule of thumb, if a property / attribute / method is public and is meant to be used by a developper outside the project, it should be documented. The suggestions I was talking about : #38 (comment), but it could be done later, it's not blocking) |
|
About |
- Because it changes a format of timepoints on "X-Axis".
- about "show_fraction", moving from "TimeSeek" to "XAxis".
- Name of example is "example-usec", but prev was "sec" xo
…ve-chart into feature-timeseek
About x_axis.show_fraction
|
I'm sorry for keeping changing public part... |
|
Good to merge ! |
|
Thank you very much for your reviewing. There are still 9 works for comitting PR... lol |
|
Don't forget, for your futur PR, to add appropriate tests. Please note that you should test the business logic, but also the rendering (i.e. what the user is seeing on the screen, have a look at https://github.com/lcallarec/live-chart/blob/master/tests/smooth_line_area.vala#L3). |
First, I'm sorry for committing 3 changes in this one PR.
This has changes about manipulating the timeline.