Skip to content

Port to GTK4#37

Merged
lcallarec merged 11 commits intolcallarec:masterfrom
taozuhong:master
Jul 23, 2023
Merged

Port to GTK4#37
lcallarec merged 11 commits intolcallarec:masterfrom
taozuhong:master

Conversation

@taozuhong
Copy link
Contributor

@taozuhong taozuhong commented Nov 2, 2022

Port all code to GTK4, hope it can make it ready for GTK4 quickly.

@taozuhong taozuhong closed this Nov 29, 2022
@taozuhong taozuhong reopened this Nov 29, 2022
@taozuhong taozuhong changed the title GTK4 Port to GTK4 Nov 29, 2022
@taozuhong
Copy link
Contributor Author

All completed.

@lcallarec
Copy link
Owner

Not sure about how many systems have GTK4 installed vs GTK3.
@stsdc : do you think switching to GTK4 is something good for your monitor application ? Or do you think that we should have 2 different builds / flavor for GTK3 & 4 ?

@lcallarec
Copy link
Owner

P.S. thanks @taozuhong for your PR :)

@stsdc
Copy link
Contributor

stsdc commented Nov 29, 2022

Right now Monitor is still on GTK3, I'm waiting elementary os to switch to newer base with GTK4 support.
If possible, I would like to have one last GTK3 release of live-chart.
I 'd like to see live-chart moving forward, therefore, I do not think that supporting two flavors will be efficient.

@lcallarec
Copy link
Owner

Fine ! @taozuhong I'll merge this PR when @stdc monitor app will be ready to move on GTK4.

@taozuhong
Copy link
Contributor Author

Honor to get it.

@stsdc
Copy link
Contributor

stsdc commented Jul 9, 2023

@lcallarec I'm ready to move to GTK4. This can be merged!

@lcallarec lcallarec merged commit d364df4 into lcallarec:master Jul 23, 2023
@lcallarec
Copy link
Owner

Merged into master. Thanks @taozuhong for your contribution, and @stsdc for your patience :)
I'm preparing a proper new release for live-chart.

@stsdc
Copy link
Contributor

stsdc commented Jul 24, 2023

Thank you! ✨👍

@taozuhong
Copy link
Contributor Author

taozuhong commented Jul 25, 2023

Great news, seems that version 2.x will coming soon.

Livechart will landed on macOS soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants