Skip to content

Support to build dynamic library and fix compile error#19

Merged
lcallarec merged 3 commits intolcallarec:masterfrom
taozuhong:master
Sep 15, 2020
Merged

Support to build dynamic library and fix compile error#19
lcallarec merged 3 commits intolcallarec:masterfrom
taozuhong:master

Conversation

@taozuhong
Copy link
Contributor

No description provided.

@taozuhong taozuhong changed the title Fixed compile error: undefined reference to `exp10' on MSYS2 Support to build dynamic library and fix compile error Sep 12, 2020
@lcallarec
Copy link
Owner

Thanks for your contribution @taozuhong !

And thanks for the tip about MSYS2 compilation :)

Just a question about the shared / dynamic library : can't you just compile / link it directly against your app ? For my own knowledge, can you explain the use case ?

Thanks !

@taozuhong
Copy link
Contributor Author

taozuhong commented Sep 15, 2020

yeah, the static library is ok for me, just want to compile it as a MINGW package for MSYS2, so it will be used by more projects.

@lcallarec
Copy link
Owner

Ok @taozuhong, I think I get the gist. I'm not aware about MINGW or similar Windows stuff, so thank you for your precious contribution !

@lcallarec lcallarec merged commit 7f9ba33 into lcallarec:master Sep 15, 2020
@taozuhong
Copy link
Contributor Author

My pleasure.

@taozuhong
Copy link
Contributor Author

image

@lcallarec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants