Split alloptions into separate cache keys#97
Merged
danielbachhuber merged 3 commits intomasterfrom Oct 31, 2016
Merged
Conversation
Doing so helps to mitigate the classic race condition described in https://core.trac.wordpress.org/ticket/31245
|
@danielbachhuber sorry I missed your message yesterday, but as you discovered, this is how we fixed this issue, not the prettiest but does work yell! |
Member
Author
|
@joehoyle Yep, turned out to be more straightforward than I expected it to be. Thanks for paving the way! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing so helps to mitigate the classic race condition described in https://core.trac.wordpress.org/ticket/31245
Inspiration from https://github.com/humanmade/memcache-object-cache/blob/master/object-cache.php#L153-L231 and https://github.com/humanmade/wordpress-pecl-memcached-object-cache/pull/1/files