fix(chainlib): reply to eth_unsubscribe instead of hanging the client#2296
Merged
Conversation
ConsumerWSSubscriptionManager.Unsubscribe returns (nil, nil) on success
because the provider-relay stream has no synchronous ack frame to forward,
which left consumer_websocket_manager writing nothing to the wire and
clients waiting until their own timeout fired (~15s). Synthesize a
JSON-RPC 2.0 §4.2-compliant {"jsonrpc":"2.0","id":<caller-id>,"result":true}
frame at the websocket layer for the (nil, nil) case, echoing the caller's
id verbatim via gjson.Raw to preserve string/number/null/object types.
Also cures the equivalent silent-hang on DirectWSSubscriptionManager's
not-last-client and upstream-no-ack branches, which share the same
(nil, nil) shape.
Verified against ws://localhost:3360/ws: unsubscribe reply now arrives in
~2ms instead of timing out at 15s.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 215 files with indirect coverage changes 🚀 New features to boost your workflow:
|
nimrod-teich
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConsumerWSSubscriptionManager.Unsubscribe returns (nil, nil) on success because the provider-relay stream has no synchronous ack frame to forward, which left consumer_websocket_manager writing nothing to the wire and clients waiting until their own timeout fired (~15s). Synthesize a JSON-RPC 2.0 §4.2-compliant {"jsonrpc":"2.0","id":,"result":true} frame at the websocket layer for the (nil, nil) case, echoing the caller's id verbatim via gjson.Raw to preserve string/number/null/object types.
Also cures the equivalent silent-hang on DirectWSSubscriptionManager's not-last-client and upstream-no-ack branches, which share the same (nil, nil) shape.
Verified locally: unsubscribe reply now arrives in ~2ms instead of timing out at 15s.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...