Conversation
Review Summary by QodoUpdate BSC average block time to 450ms
WalkthroughsDescription• Update BSC average block time from 750ms to 450ms • Apply changes to both mainnet and testnet specifications • Align block time with actual BSC network parameters Diagramflowchart LR
A["BSC Specs<br/>average_block_time: 750ms"] -- "Update to 450ms" --> B["BSC Specs<br/>average_block_time: 450ms"]
C["BSCT Specs<br/>average_block_time: 750ms"] -- "Update to 450ms" --> D["BSCT Specs<br/>average_block_time: 450ms"]
File Changes1. specs/mainnet-1/specs/bsc.json
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 📐 Spec deviations (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
Comment on lines
14
to
18
| "data_reliability_enabled": true, | ||
| "block_distance_for_finalized_data": 0, | ||
| "blocks_in_finalization_proof": 1, | ||
| "average_block_time": 750, | ||
| "average_block_time": 450, | ||
| "allowed_block_lag_for_qos_sync": 14, |
There was a problem hiding this comment.
average_block_time is 450 but consumers treat it as milliseconds while BSC's block time is ≈3000 ms, should we set average_block_time to ≈3000 in both BSC and BSCT specs?
Finding type: Logical Bugs | Severity: 🔴 High
Want Baz to fix this for you? Activate Fixer
Other fix methods
Prompt for AI Agents:
Before applying, verify this suggestion against the current code. In
specs/mainnet-1/specs/bsc.json around lines 14-18 and 59-63, the average_block_time is
set to 450 (ms) which is incorrect for Binance Smart Chain and will cause timeouts and
sync checks to be too aggressive. Change both values from 450 to approximately 3000
(milliseconds) to reflect the real BSC average block time; also search for and update
any corresponding BSCT spec files to the same ~3000 ms value so derived TTLs and polling
cadences remain correct. Run configuration validation and any integration tests to
ensure derived timeouts behave as expected.
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Correct the BSC network specification loader by setting
average_block_timeto 450ms so QoS and validation thresholds use realistic block pacing. Apply this timing across the mainnet-1 and testnet-2 spec data to keep provider staking parameters consistent.Latest Contributors(2)