Skip to content

feat: Bump protocol version to v6.0.1#2233

Merged
nimrod-teich merged 1 commit into
mainfrom
upgrade-v6.0.1
Mar 4, 2026
Merged

feat: Bump protocol version to v6.0.1#2233
nimrod-teich merged 1 commit into
mainfrom
upgrade-v6.0.1

Conversation

@nimrod-teich

Copy link
Copy Markdown
Contributor

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@qodo-code-review

Copy link
Copy Markdown

Review Summary by Qodo

Bump protocol version to v6.0.1

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Bumps protocol TARGET_VERSION from 6.0.0 to 6.0.1
• Updates version constant in protocol parameters
Diagram
flowchart LR
  A["Protocol Version 6.0.0"] -- "Update TARGET_VERSION constant" --> B["Protocol Version 6.0.1"]
Loading

Grey Divider

File Changes

1. x/protocol/types/params.go ⚙️ Configuration changes +1/-1

Update protocol TARGET_VERSION constant

• Updated TARGET_VERSION constant from "6.0.0" to "6.0.1"
• Maintains MIN_VERSION at "5.5.1"

x/protocol/types/params.go


Grey Divider

Qodo Logo

@qodo-code-review

qodo-code-review Bot commented Mar 4, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Advisory comments

1. Advertised version changes globally 🐞 Bug ⛯ Reliability
Description
TARGET_VERSION feeds protocoltypes.DefaultVersion, which is used as the locally-advertised
provider/consumer version in RPC metadata and other components. After this bump, binaries will
advertise 6.0.1; if the network’s on-chain target version or upgrade artifacts aren’t updated in
lockstep, this can produce “version > target” warnings and complicate debugging/operations.
Code

x/protocol/types/params.go[15]

+	TARGET_VERSION = "6.0.1"
Evidence
The PR updates TARGET_VERSION, which directly sets DefaultVersion.ProviderTarget/ConsumerTarget.
DefaultVersion is then used to populate the globally reported protocol version (via
upgrade.GetCurrentVersion()), which is attached to provider trailers and consumer metadata
headers. Lavavisor also has explicit warning behavior when the running binary version is greater
than the target version it is trying to fetch/align to, which may surface during rollout if versions
are temporarily out of sync.

x/protocol/types/params.go[14-27]
protocol/upgrade/protocol_version.go[17-20]
protocol/rpcprovider/rpcprovider_server.go[1482-1486]
protocol/rpcconsumer/rpcconsumer_server.go[2139-2143]
ecosystem/lavavisor/pkg/process/fetcher.go[80-85]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`TARGET_VERSION` updates `DefaultVersion`, which is used to advertise the running protocol version across RPC metadata and tooling. This is fine, but it requires rollout coordination so the advertised version, on-chain target/min params, and Lavavisor upgrade artifacts don’t drift.

## Issue Context
Changing `TARGET_VERSION` to 6.0.1 will cause binaries to report 6.0.1 immediately, independent of when governance/on-chain params are updated.

## Fix Focus Areas
- x/protocol/types/params.go[14-27]
- protocol/upgrade/protocol_version.go[17-20]
- protocol/rpcprovider/rpcprovider_server.go[1482-1486]
- protocol/rpcconsumer/rpcconsumer_server.go[2139-2143]
- ecosystem/lavavisor/pkg/process/fetcher.go[80-85]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@codecov

codecov Bot commented Mar 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
consensus 8.71% <ø> (ø)
protocol 34.62% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
x/protocol/types/params.go 51.21% <ø> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nimrod-teich nimrod-teich merged commit ffece61 into main Mar 4, 2026
28 checks passed
@nimrod-teich nimrod-teich deleted the upgrade-v6.0.1 branch March 4, 2026 09:47
@nimrod-teich nimrod-teich restored the upgrade-v6.0.1 branch March 19, 2026 10:17
@NadavLevi NadavLevi deleted the upgrade-v6.0.1 branch March 27, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants