feat: bump target version to 6.0.0#2230
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Review Summary by QodoBump target version to 6.0.0
WalkthroughsDescription• Bump target version constant to 6.0.0 • Updates TARGET_VERSION in protocol params configuration Diagramflowchart LR
A["TARGET_VERSION<br/>5.6.2"] -- "version bump" --> B["TARGET_VERSION<br/>6.0.0"]
File Changes1. x/protocol/types/params.go
|
Code Review by Qodo
1. Lavavisor infinite loop risk
|
| TARGET_VERSION = "6.0.0" | ||
| MIN_VERSION = "5.5.1" |
There was a problem hiding this comment.
1. Lavavisor infinite loop risk 🐞 Bug ⛯ Reliability
With TARGET_VERSION set to 6.0.0, lavavisor’s binary fetch loop can become non-terminating if v6.0.0 isn’t available, because the version-decrement helper is a no-op at X.0.0. This can hang upgrades/startup instead of falling back within the [min,target] range.
Agent Prompt
## Issue description
With protocol `TARGET_VERSION` bumped to `6.0.0`, lavavisor may enter an infinite loop when it fails to fetch the `v6.0.0` binary (missing local dir / download failure). The loop attempts to decrement the version until `minVersion`, but `DecrementVersion()` is a no-op at `X.0.0` because it never decrements `Major`.
## Issue Context
Lavavisor’s fetch loop decrements from `ProviderTarget` down to `ProviderMin` to find an available binary. With `ProviderTarget=6.0.0` and `ProviderMin=5.5.1`, a failure to fetch `6.0.0` should fall back to `5.x`, but cannot.
## Fix Focus Areas
- ecosystem/lavavisor/pkg/util/common.go[98-106]
- ecosystem/lavavisor/pkg/process/fetcher.go[61-92]
- ecosystem/lavavisor/pkg/process/fetcher_without_build.go[59-92]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...