Skip to content

feat: bump target version to 6.0.0#2230

Merged
nimrod-teich merged 1 commit into
mainfrom
feat/bump-version-6.0.0
Feb 23, 2026
Merged

feat: bump target version to 6.0.0#2230
nimrod-teich merged 1 commit into
mainfrom
feat/bump-version-6.0.0

Conversation

@nimrod-teich

Copy link
Copy Markdown
Contributor

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Co-authored-by: Cursor <cursoragent@cursor.com>
@qodo-code-review

Copy link
Copy Markdown

Review Summary by Qodo

Bump target version to 6.0.0

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Bump target version constant to 6.0.0
• Updates TARGET_VERSION in protocol params configuration
Diagram
flowchart LR
  A["TARGET_VERSION<br/>5.6.2"] -- "version bump" --> B["TARGET_VERSION<br/>6.0.0"]
Loading

Grey Divider

File Changes

1. x/protocol/types/params.go ⚙️ Configuration changes +1/-1

Update target version constant to 6.0.0

• Updated TARGET_VERSION constant from "5.6.2" to "6.0.0"
• MIN_VERSION remains unchanged at "5.5.1"

x/protocol/types/params.go


Grey Divider

Qodo Logo

@qodo-code-review

qodo-code-review Bot commented Feb 23, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Action required

1. Lavavisor infinite loop risk 🐞 Bug ⛯ Reliability
Description
With TARGET_VERSION set to 6.0.0, lavavisor’s binary fetch loop can become non-terminating if v6.0.0
isn’t available, because the version-decrement helper is a no-op at X.0.0. This can hang
upgrades/startup instead of falling back within the [min,target] range.
Code

x/protocol/types/params.go[R15-16]

+	TARGET_VERSION = "6.0.0"
	MIN_VERSION    = "5.5.1"
Evidence
The PR sets the on-chain default ProviderTarget/ConsumerTarget to 6.0.0. Clients (lavavisor) read
this value from the chain and attempt to fetch a protocol binary by iterating from ProviderTarget
down to ProviderMin, decrementing the semantic version each iteration. The decrement function does
not implement the documented Major decrement when Minor==0 and Patch==0, so when the target is 6.0.0
and the initial fetch attempt fails, the loop never progresses and never terminates.

x/protocol/types/params.go[14-26]
protocol/statetracker/updaters/state_query.go[128-140]
ecosystem/lavavisor/pkg/process/fetcher.go[61-92]
ecosystem/lavavisor/pkg/util/common.go[98-106]
x/protocol/keeper/migrations.go[18-22]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
With protocol `TARGET_VERSION` bumped to `6.0.0`, lavavisor may enter an infinite loop when it fails to fetch the `v6.0.0` binary (missing local dir / download failure). The loop attempts to decrement the version until `minVersion`, but `DecrementVersion()` is a no-op at `X.0.0` because it never decrements `Major`.

## Issue Context
Lavavisor’s fetch loop decrements from `ProviderTarget` down to `ProviderMin` to find an available binary. With `ProviderTarget=6.0.0` and `ProviderMin=5.5.1`, a failure to fetch `6.0.0` should fall back to `5.x`, but cannot.

## Fix Focus Areas
- ecosystem/lavavisor/pkg/util/common.go[98-106]
- ecosystem/lavavisor/pkg/process/fetcher.go[61-92]
- ecosystem/lavavisor/pkg/process/fetcher_without_build.go[59-92]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

Comment on lines +15 to 16
TARGET_VERSION = "6.0.0"
MIN_VERSION = "5.5.1"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Lavavisor infinite loop risk 🐞 Bug ⛯ Reliability

With TARGET_VERSION set to 6.0.0, lavavisor’s binary fetch loop can become non-terminating if v6.0.0
isn’t available, because the version-decrement helper is a no-op at X.0.0. This can hang
upgrades/startup instead of falling back within the [min,target] range.
Agent Prompt
## Issue description
With protocol `TARGET_VERSION` bumped to `6.0.0`, lavavisor may enter an infinite loop when it fails to fetch the `v6.0.0` binary (missing local dir / download failure). The loop attempts to decrement the version until `minVersion`, but `DecrementVersion()` is a no-op at `X.0.0` because it never decrements `Major`.

## Issue Context
Lavavisor’s fetch loop decrements from `ProviderTarget` down to `ProviderMin` to find an available binary. With `ProviderTarget=6.0.0` and `ProviderMin=5.5.1`, a failure to fetch `6.0.0` should fall back to `5.x`, but cannot.

## Fix Focus Areas
- ecosystem/lavavisor/pkg/util/common.go[98-106]
- ecosystem/lavavisor/pkg/process/fetcher.go[61-92]
- ecosystem/lavavisor/pkg/process/fetcher_without_build.go[59-92]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@codecov

codecov Bot commented Feb 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
consensus 8.71% <ø> (ø)
protocol 34.49% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
x/protocol/types/params.go 51.21% <ø> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nimrod-teich nimrod-teich merged commit b2961ad into main Feb 23, 2026
28 checks passed
@nimrod-teich nimrod-teich deleted the feat/bump-version-6.0.0 branch February 23, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant