feat: restore provider-side consistency checks with CLI flag#2223
Merged
Conversation
Re-enable the handleConsistency feature that was accidentally removed during the DR removal commit. The implementation matches feature/refactor-tiers exactly, but adds a CLI flag for control. Changes: - Add --disable-consistency-checks flag (consistency enabled by default) - Conditionally call handleConsistency based on flag - Update GetParametersForCache signature to accept latestBlock parameter - When enabled: provider waits for chain tracker to catch up with consumer's seen block - When disabled: provider responds immediately with current state The existing handleConsistency, SleepUntilTimeOrConditionReached, and GetLatestBlockData methods that were already in the branch are now utilized. Co-authored-by: Cursor <cursoragent@cursor.com>
- Add --disable-consistency-checks flag (consistency enabled by default) - Add enableConsistencyChecks field to RPCProvider struct - Pass enableConsistencyChecks through to ServeRPCRequests The consistency feature ensures providers wait for their chain tracker to catch up with consumer's seenBlock before responding, preventing stale data responses. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Drop unused block-hash range fetching from handleConsistency and remove the dead error return from GetParametersForCache. Co-authored-by: Cursor <cursoragent@cursor.com>
Add unit tests for handleConsistency branches and ensure the disable-consistency-checks flag is registered. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Use sentinel errors for unimplemented fake parser methods and return empty slices instead of nil to satisfy nilnil. Format with gofumpt. Co-authored-by: Cursor <cursoragent@cursor.com>
avitenzer
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enable the handleConsistency feature that was accidentally removed during the DR removal commit. The implementation matches feature/refactor-tiers exactly, but adds a CLI flag for control.
Changes:
The existing handleConsistency, SleepUntilTimeOrConditionReached, and GetLatestBlockData methods that were already in the branch are now utilized.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...