fix: use buffered channel to prevent deadlock in state machine#2215
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
75aa056 to
cc1baed
Compare
NadavLevi
previously approved these changes
Feb 15, 2026
The relayTaskChannel was created as an unbuffered channel, which could cause a deadlock when the receiving goroutine exits prematurely (e.g., due to context cancellation or errors). In this scenario, sends to the channel would block indefinitely since there's no receiver. This fix adds a buffer of 1 to the channel, allowing the sender to proceed even if the receiver has exited, preventing potential deadlocks.
The relayTaskChannel was created as an unbuffered channel in both SmartRouterRelayStateMachine and ConsumerRelayStateMachine, which could cause a deadlock when the receiving goroutine exits prematurely (e.g., due to context cancellation or errors). In this scenario, sends to the channel would block indefinitely since there's no receiver. This fix adds a buffer of 1 to the channel, allowing the sender to proceed even if the receiver has exited, preventing potential deadlocks. Files changed: - protocol/rpcsmartrouter/smartrouter_relay_state_machine.go - protocol/rpcconsumer/consumer_relay_state_machine.go - protocol/rpcsmartrouter/smartrouter_relay_state_machine_test.go (tests) - protocol/rpcconsumer/consumer_relay_state_machine_test.go (tests)
cc1baed to
dcbc111
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The relayTaskChannel was created as an unbuffered channel, which could cause a deadlock when the receiving goroutine exits prematurely (e.g., due to context cancellation or errors). In this scenario, sends to the channel would block indefinitely since there's no receiver.
This fix adds a buffer of 1 to the channel, allowing the sender to proceed even if the receiver has exited, preventing potential deadlocks.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...