fix: stop ticker to prevent goroutine leak in PeriodicProbeProviders#2214
Merged
Conversation
The ticker created in PeriodicProbeProviders was not being stopped when the function returned via ctx.Done(). This caused a goroutine leak as the ticker's internal goroutine would continue running. This fix adds defer ticker.Stop() to ensure the ticker is properly cleaned up when the function exits.
Add TestPeriodicProbeProvidersTickerCleanup with three test cases: - Verify function exits promptly when context is cancelled - Test multiple probe sessions all exit cleanly on cancellation - Verify ticker fires and is properly cleaned up These tests validate the fix that added defer ticker.Stop() to prevent goroutine leaks when the function exits.
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
NadavLevi
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ticker created in PeriodicProbeProviders was not being stopped when the function returned via ctx.Done(). This caused a goroutine leak as the ticker's internal goroutine would continue running.
This fix adds defer ticker.Stop() to ensure the ticker is properly cleaned up when the function exits.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...