perf(protocol): optimize logging for performance and aggregation#2212
Merged
Conversation
Replace premature fmt.Sprintf calls in log statements with structured logging attributes. This avoids string allocation and formatting when the log level is disabled, improving performance in hot paths.
Replace inefficient string concatenation in a loop with strings.Builder. The previous implementation created O(n^2) allocations due to += in a loop. Also pre-allocate the eventAttrs slice to avoid reallocations.
Only create rolling logger events when the rolling logger is enabled. Previously, events were created for all severity levels except PANIC/FATAL even when the rolling logger was disabled, causing unnecessary allocations. Also add nil checks to avoid method calls on nil events.
Move dynamic values from log message strings to structured attributes to enable proper log aggregation. Messages like "chainID could not get provider" now become "could not get provider" with chainID as attribute.
Add GUID to log statements where context is available to enable better correlation and tracing of requests across log entries.
NadavLevi
approved these changes
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves logging performance and enables better log aggregation across the protocol layer.
Performance Optimizations
Use structured logging instead of
fmt.Sprintf: Replace premature string formatting with structuredLogAttrattributes. This avoids allocations when log levels are disabled (e.g., DEBUG/TRACE in production).Use
strings.BuilderinLogLavaEventWithLevel: Fix O(n²) string concatenation in a loop that was creating unnecessary allocations.Skip rolling logger event creation when disabled: Only create zerolog events for the rolling logger when it's actually enabled, avoiding allocations for unused events.
Log Aggregation Improvements
Move dynamic values to structured attributes: Messages like
"chainID could not get provider"now become"could not get provider"withchainIDas an attribute. This enables proper grouping of similar errors in log aggregation tools (Grafana Loki, Datadog, etc.).Add missing GUID attributes: Ensure request correlation by adding GUID to log statements where context is available but wasn't being logged.
Changes
utils/lavalog.gostrings.Builder, add rolling logger guardsprotocol/relaycore/relay_processor.goprotocol/rpcconsumer/rpcconsumer_server.goprotocol/rpcsmartrouter/rpcsmartrouter_server.goprotocol/rpcprovider/rpcprovider_server.goprotocol/lavasession/consumer_session_manager.goprotocol/chainlib/*.goprotocol/metrics/queue_sender.goTest plan
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...