Skip to content

refactor: rename Quorum feature to CrossValidation#2211

Merged
nimrod-teich merged 1 commit into
mainfrom
refactor/rename-quorum-to-cross-validation
Jan 29, 2026
Merged

refactor: rename Quorum feature to CrossValidation#2211
nimrod-teich merged 1 commit into
mainfrom
refactor/rename-quorum-to-cross-validation

Conversation

@nimrod-teich

Copy link
Copy Markdown
Contributor

Rename the Quorum feature to CrossValidation throughout the codebase for better clarity. The term "Quorum" was ambiguous as it was also previously used for a selection strategy (now called Stateless).

Changes include:

  • QuorumParams → CrossValidationParams
  • DefaultQuorumParams → DefaultCrossValidationParams
  • Quorum field in RelayResult → CrossValidation
  • QUORUM_HEADER_* constants → CROSS_VALIDATION_HEADER_*
  • GetQuorumParams() → GetCrossValidationParams()
  • getRequiredQuorumSize() → getRequiredCrossValidationSize()
  • responsesQuorum() → responsesCrossValidation()
  • quorumParams/quorumMap fields → crossValidationParams/crossValidationMap
  • HTTP header values updated (breaking change for clients)

Also fixes incorrect renames where "quorum" referred to the Stateless selection strategy rather than the CrossValidation feature.

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Rename the Quorum feature to CrossValidation throughout the codebase
for better clarity. The term "Quorum" was ambiguous as it was also
previously used for a selection strategy (now called Stateless).

Changes include:
- QuorumParams → CrossValidationParams
- DefaultQuorumParams → DefaultCrossValidationParams
- Quorum field in RelayResult → CrossValidation
- QUORUM_HEADER_* constants → CROSS_VALIDATION_HEADER_*
- GetQuorumParams() → GetCrossValidationParams()
- getRequiredQuorumSize() → getRequiredCrossValidationSize()
- responsesQuorum() → responsesCrossValidation()
- quorumParams/quorumMap fields → crossValidationParams/crossValidationMap
- HTTP header values updated (breaking change for clients)

Also fixes incorrect renames where "quorum" referred to the Stateless
selection strategy rather than the CrossValidation feature.
@codecov

codecov Bot commented Jan 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 41.11111% with 106 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
protocol/relaycore/relay_processor.go 64.13% 30 Missing and 3 partials ⚠️
protocol/chainlib/protocol_message.go 0.00% 25 Missing ⚠️
protocol/rpcconsumer/rpcconsumer_server.go 22.22% 17 Missing and 4 partials ⚠️
protocol/rpcsmartrouter/rpcsmartrouter_server.go 22.22% 17 Missing and 4 partials ⚠️
protocol/common/types.go 0.00% 2 Missing ⚠️
protocol/relaycore/relay_errors.go 0.00% 1 Missing ⚠️
protocol/relaycore/results_manager.go 0.00% 1 Missing ⚠️
...otocol/rpcconsumer/consumer_relay_state_machine.go 50.00% 0 Missing and 1 partial ⚠️
.../rpcsmartrouter/smartrouter_relay_state_machine.go 50.00% 0 Missing and 1 partial ⚠️
Flag Coverage Δ
consensus 8.55% <0.00%> (ø)
protocol 33.82% <41.11%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
protocol/common/endpoints.go 0.00% <ø> (ø)
protocol/metrics/consumer_metrics_manager.go 48.17% <100.00%> (ø)
protocol/relaycore/interfaces.go 0.00% <ø> (ø)
protocol/relaycore/relay_errors.go 51.42% <0.00%> (ø)
protocol/relaycore/results_manager.go 67.62% <0.00%> (ø)
...otocol/rpcconsumer/consumer_relay_state_machine.go 81.65% <50.00%> (ø)
.../rpcsmartrouter/smartrouter_relay_state_machine.go 88.23% <50.00%> (ø)
protocol/common/types.go 0.00% <0.00%> (ø)
protocol/rpcconsumer/rpcconsumer_server.go 30.34% <22.22%> (ø)
protocol/rpcsmartrouter/rpcsmartrouter_server.go 31.65% <22.22%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nimrod-teich nimrod-teich merged commit 3a59b97 into main Jan 29, 2026
29 checks passed
@nimrod-teich nimrod-teich deleted the refactor/rename-quorum-to-cross-validation branch January 29, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants