Skip to content

fix(lavasession): skip connection purge for static providers#2209

Merged
nimrod-teich merged 1 commit into
mainfrom
fix/static-provider-connection-purge
Jan 29, 2026
Merged

fix(lavasession): skip connection purge for static providers#2209
nimrod-teich merged 1 commit into
mainfrom
fix/static-provider-connection-purge

Conversation

@NadavLevi

Copy link
Copy Markdown
Contributor

Static providers (used by smart router) reuse the same Endpoint objects across epochs. The closePurgedUnusedPairingsConnections function was closing these shared connections during epoch transitions, causing "grpc: the client connection is closing" errors for in-flight requests.

This fix skips connection purging for StaticProvider sessions since their connections are intentionally shared and should persist for the lifetime of the process.

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Static providers (used by smart router) reuse the same Endpoint objects
across epochs. The closePurgedUnusedPairingsConnections function was
closing these shared connections during epoch transitions, causing
"grpc: the client connection is closing" errors for in-flight requests.

This fix skips connection purging for StaticProvider sessions since their
connections are intentionally shared and should persist for the lifetime
of the process.
@codecov

codecov Bot commented Jan 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
protocol/lavasession/consumer_session_manager.go 0.00% 5 Missing ⚠️
Flag Coverage Δ
consensus 8.55% <ø> (+<0.01%) ⬆️
protocol 33.82% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
protocol/lavasession/consumer_session_manager.go 62.55% <0.00%> (+0.09%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nimrod-teich nimrod-teich merged commit a6f13a2 into main Jan 29, 2026
28 of 29 checks passed
@nimrod-teich nimrod-teich deleted the fix/static-provider-connection-purge branch January 29, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants