fix: goroutine leaks#2206
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
d5b223b to
079d3e6
Compare
d82099a to
ea5a923
Compare
ad28dff to
04b9a74
Compare
Replace polling goroutine with context-aware WaitForStateChange loop: - Use conn.WaitForStateChange(ctx, state) to wait for connection readiness - Return connectCtx.Err() and close connection on timeout/cancel - No goroutine spawned, eliminating leak risk entirely Add goleak-based regression tests that verify: - No goroutines leaked on timeout - Prompt return on context cancellation - Successful connections still work correctly
Add sync.RWMutex to Endpoint struct to protect concurrent access to Connections, ConnectionRefusals, and Enabled fields. Use explicit lock scopes to avoid holding lock during network calls: - Lock for cleanup and existing connection selection - Explicit unlock before network dial (not deferred across dial) - Re-lock with defer for state updates after dial This pattern is safer than Lock+defer Unlock with manual unlock/lock around the dial, which risks double-unlock panics if control flow changes.
04b9a74 to
a3ee2d6
Compare
AnnaR-prog
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...