Skip to content

fix: add BatchNodeErrorOnAny flag and fix state machine test#2205

Merged
nimrod-teich merged 1 commit into
mainfrom
fix/batch-node-error-flag-and-test
Jan 28, 2026
Merged

fix: add BatchNodeErrorOnAny flag and fix state machine test#2205
nimrod-teich merged 1 commit into
mainfrom
fix/batch-node-error-flag-and-test

Conversation

@nimrod-teich

Copy link
Copy Markdown
Contributor
  • Add --batch-node-error-on-any CLI flag to control batch request error detection (false=error only if ALL fail, true=error if ANY fails)
  • Fix TestConsumerStateMachineHappyFlow by setting RelayCountOnNodeError=4 to allow enough retries for the test scenario

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

NadavLevi
NadavLevi previously approved these changes Jan 28, 2026
@codecov

codecov Bot commented Jan 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
protocol/rpcconsumer/rpcconsumer.go 0.00% 1 Missing ⚠️
protocol/rpcsmartrouter/rpcsmartrouter.go 0.00% 1 Missing ⚠️
Flag Coverage Δ
consensus 8.53% <ø> (ø)
protocol 33.81% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
protocol/common/cobra_common.go 0.00% <ø> (ø)
protocol/rpcconsumer/rpcconsumer.go 0.00% <0.00%> (ø)
protocol/rpcsmartrouter/rpcsmartrouter.go 4.55% <0.00%> (-0.01%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown

Test Results

    7 files  ±0     85 suites  ±0   30m 42s ⏱️ - 1m 7s
3 196 tests ±0  3 195 ✅ ±0  1 💤 ±0  0 ❌ ±0 
3 279 runs  ±0  3 278 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 6cb3cdd. ± Comparison against base commit 2ae0fd6.

- Add --batch-node-error-on-any CLI flag to control batch request error
  detection (false=error only if ALL fail, true=error if ANY fails)
- Fix TestConsumerStateMachineHappyFlow by setting RelayCountOnNodeError=4
  to allow enough retries for the test scenario
@nimrod-teich nimrod-teich force-pushed the fix/batch-node-error-flag-and-test branch from 6cb3cdd to 11b2f4a Compare January 28, 2026 14:52
@nimrod-teich nimrod-teich merged commit c256fe2 into main Jan 28, 2026
@nimrod-teich nimrod-teich deleted the fix/batch-node-error-flag-and-test branch January 28, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants