fix: Unsupported method handling#2198
Merged
Merged
Conversation
commit fb63065 Author: Tomelia1999 <tom.elia99@gmail.com> Date: Wed Jan 21 13:58:54 2026 +0100 remove functionality duplication commit 37251cb Author: Tomelia1999 <tom.elia99@gmail.com> Date: Thu Jan 15 18:32:01 2026 +0200 WIP: unsupported method - bytes comparison instead of stign comparison commit 298dce8 Author: Tomelia1999 <tom.elia99@gmail.com> Date: Mon Jan 5 18:19:16 2026 +0200 unify functions + adding unit tests commit 057da85 Author: Tomelia1999 <tom.elia99@gmail.com> Date: Mon Jan 5 14:54:35 2026 +0200 improve flow of unsupported method
Test Results 7 files ± 0 85 suites ±0 30m 22s ⏱️ - 3m 5s Results for commit 5787102. ± Comparison against base commit f0e3d53. This pull request removes 9 and adds 146 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Tomelia1999
commented
Jan 22, 2026
| return true | ||
| } | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I think we can remove that part below (iterating protocol errors and looking for unsupportedMethod errors), since that fix do not return the unsupportedMethods errors as a protocol error.
We only need to extract the epochMismatch validation and put it in a dedicated function, since "HasUnsupportedMethodErrors" is not the appropriate peace of code to host that validation.
waiting for reviewers opinion.
Contributor
Author
There was a problem hiding this comment.
nimrod-teich
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...