Skip to content

fix(metrics): expose latency metric for batch requests#2195

Merged
nimrod-teich merged 1 commit into
mainfrom
fix/batch_latency
Jan 20, 2026
Merged

fix(metrics): expose latency metric for batch requests#2195
nimrod-teich merged 1 commit into
mainfrom
fix/batch_latency

Conversation

@NadavLevi

Copy link
Copy Markdown
Contributor

Batch requests were not recording latency in the
lava_provider_request_latency_per_function metric because GetRawRequestHash() intentionally returns WontCalculateBatchHash for batches, causing the code to break early and return emptyTime (0ms).

This fix detects batch requests explicitly and returns immediately with the actual latency, while preserving the original retry behavior for single requests that fail to hash unexpectedly.

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Batch requests were not recording latency in the
lava_provider_request_latency_per_function metric because
GetRawRequestHash() intentionally returns WontCalculateBatchHash
for batches, causing the code to break early and return emptyTime (0ms).

This fix detects batch requests explicitly and returns immediately
with the actual latency, while preserving the original retry behavior
for single requests that fail to hash unexpectedly.
@codecov

codecov Bot commented Jan 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
protocol/rpcprovider/provider_state_machine.go 37.50% 2 Missing and 3 partials ⚠️
Flag Coverage Δ
consensus 8.53% <ø> (ø)
protocol 33.76% <37.50%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
protocol/rpcprovider/provider_state_machine.go 64.86% <37.50%> (-0.42%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown

Test Results

    7 files  ±0     85 suites  ±0   33m 38s ⏱️ - 1m 18s
3 181 tests ±0  3 180 ✅ ±0  1 💤 ±0  0 ❌ ±0 
3 264 runs  ±0  3 263 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 6ba0388. ± Comparison against base commit 9d5b671.

@nimrod-teich nimrod-teich merged commit 3cdd68b into main Jan 20, 2026
31 checks passed
@nimrod-teich nimrod-teich deleted the fix/batch_latency branch January 20, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants