fix: minor performance optimization#2178
Merged
Merged
Conversation
nimrod-teich
previously approved these changes
Jan 11, 2026
…mory allocation The testing_helpers.go file was creating a RelayRetriesManager with a ~200MB ristretto cache at package init time, even in production builds. Changes: - Renamed protocol/relaycore/testing_helpers.go to testing_helpers_test.go (only compiled during tests for internal package tests) - Created protocol/relaycoretest/ package for external test packages to import - Updated test files in rpcconsumer and rpcsmartrouter to use relaycoretest This eliminates ~200MB of unnecessary memory allocation in production builds.
Eliminated duplicate GetReqHeaders() calls in HTTP handlers: - jsonRPC.go: Reuse metadataValues in AddMetricForHttp() - tendermintRPC.go: Same optimization (2 locations) - rest.go: Same optimization (2 locations) Each GetReqHeaders() call creates a new map allocation. At 1000 req/s, eliminating the duplicate call saves ~2000 map allocations per second, reducing header-related memory pressure by ~50%.
4578781 to
8f3d9f5
Compare
nimrod-teich
approved these changes
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...