Skip to content

feat: add configurable flags for pyroscope mutex and block profiling#2173

Merged
nimrod-teich merged 1 commit into
mainfrom
feature/pyroscope-profiling-flags
Jan 6, 2026
Merged

feat: add configurable flags for pyroscope mutex and block profiling#2173
nimrod-teich merged 1 commit into
mainfrom
feature/pyroscope-profiling-flags

Conversation

@nimrod-teich

Copy link
Copy Markdown
Contributor

Add command-line flags to configure mutex profile fraction and block profile rate for pyroscope profiling instead of using hardcoded values:

  • --pyroscope-mutex-profile-fraction: sampling rate for mutex profiling (default: 5)
  • --pyroscope-block-profile-rate: block profile rate in nanoseconds (default: 1)

Flags are available on rpcprovider, rpcconsumer, and rpcsmartrouter commands.

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

NadavLevi
NadavLevi previously approved these changes Jan 6, 2026
@github-actions

github-actions Bot commented Jan 6, 2026

Copy link
Copy Markdown

Test Results

    6 files   -   1    129 suites   - 2   34m 34s ⏱️ +8s
2 912 tests  - 307  2 906 ✅  - 312  1 💤 ±0  0 ❌ ±0  5 🔥 +5 
2 992 runs   - 307  2 986 ✅  - 312  1 💤 ±0  0 ❌ ±0  5 🔥 +5 

For more details on these errors, see this check.

Results for commit 5e21c81. ± Comparison against base commit 087295c.

This pull request removes 307 tests.
github.com/lavanet/lava/v5/ecosystem/cache ‑ TestCacheExpirationMultiplier
github.com/lavanet/lava/v5/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_1
github.com/lavanet/lava/v5/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_1.2
github.com/lavanet/lava/v5/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_2
github.com/lavanet/lava/v5/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_2.5
github.com/lavanet/lava/v5/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_200
github.com/lavanet/lava/v5/ecosystem/cache ‑ TestCacheFailSetWithInvalidRequestBlock
github.com/lavanet/lava/v5/ecosystem/cache ‑ TestCacheFailSetWithInvalidRequestBlock/Finalized_After_delay_No_Hash
github.com/lavanet/lava/v5/ecosystem/cache ‑ TestCacheFailSetWithInvalidRequestBlock/Finalized_After_delay_No_Hash#01
github.com/lavanet/lava/v5/ecosystem/cache ‑ TestCacheFailSetWithInvalidRequestBlock/Finalized_After_delay_With_Hash
…

Add command-line flags to configure pyroscope profiling:

- --pyroscope-mutex-profile-fraction: sampling rate for mutex profiling (default: 5)
- --pyroscope-block-profile-rate: block profile rate in nanoseconds (default: 1)
- --pyroscope-tags: comma-separated list of tags in key=value format
  (e.g., instance=provider-1,region=us-east)

Tags allow multiple instances to be grouped under the same application name
while remaining distinguishable in the Pyroscope UI.

Flags are available on rpcprovider, rpcconsumer, and rpcsmartrouter commands.
@nimrod-teich nimrod-teich force-pushed the feature/pyroscope-profiling-flags branch from 5e21c81 to a0ebddb Compare January 6, 2026 13:30
@nimrod-teich nimrod-teich merged commit 0467913 into main Jan 6, 2026
9 checks passed
@nimrod-teich nimrod-teich deleted the feature/pyroscope-profiling-flags branch January 6, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants