Skip to content

feat: add Pyroscope continuous profiling support#2172

Merged
nimrod-teich merged 1 commit into
mainfrom
feature/pyroscope-profiling
Jan 5, 2026
Merged

feat: add Pyroscope continuous profiling support#2172
nimrod-teich merged 1 commit into
mainfrom
feature/pyroscope-profiling

Conversation

@nimrod-teich

@nimrod-teich nimrod-teich commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

Add --pyroscope-address flag to enable continuous profiling via Pyroscope.
Add --pyroscope-app-name flag to customize the application name reported
to Pyroscope (defaults to lavap-consumer/lavap-provider/lavap-smartrouter).

When the address flag is provided, the application connects to the specified
Pyroscope server and sends profiling data for CPU, memory allocations,
memory in-use, and goroutines.

Supported commands:

  • lavap rpcconsumer (default app name: lavap-consumer)
  • lavap rpcprovider (default app name: lavap-provider)
  • lavap rpcsmartrouter (default app name: lavap-smartrouter)

Usage example:
lavap rpcconsumer --pyroscope-address http://pyroscope:4040 --pyroscope-app-name my-consumer ...

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@github-actions

github-actions Bot commented Jan 5, 2026

Copy link
Copy Markdown

Test Results

    7 files  ±0    131 suites  ±0   33m 52s ⏱️ -47s
3 219 tests ±0  3 218 ✅ ±0  1 💤 ±0  0 ❌ ±0 
3 299 runs  ±0  3 298 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 7f2c151. ± Comparison against base commit b29650c.

@nimrod-teich nimrod-teich force-pushed the feature/pyroscope-profiling branch from 7f2c151 to 54ef027 Compare January 5, 2026 15:18
@pull-request-size pull-request-size Bot added size/L and removed size/M labels Jan 5, 2026
NadavLevi
NadavLevi previously approved these changes Jan 5, 2026
Add --pyroscope-address flag to enable continuous profiling via Pyroscope.
Add --pyroscope-app-name flag to customize the application name reported
to Pyroscope (defaults to lavap-consumer/lavap-provider/lavap-smartrouter).

When the address flag is provided, the application connects to the specified
Pyroscope server and sends profiling data for CPU, memory allocations,
memory in-use, and goroutines.

Supported commands:
- lavap rpcconsumer (default app name: lavap-consumer)
- lavap rpcprovider (default app name: lavap-provider)
- lavap rpcsmartrouter (default app name: lavap-smartrouter)

Usage example:
  lavap rpcconsumer --pyroscope-address http://pyroscope:4040 --pyroscope-app-name my-consumer ...
@nimrod-teich nimrod-teich force-pushed the feature/pyroscope-profiling branch from 54ef027 to 0d68da7 Compare January 5, 2026 15:20
@nimrod-teich nimrod-teich merged commit 087295c into main Jan 5, 2026
28 checks passed
@nimrod-teich nimrod-teich deleted the feature/pyroscope-profiling branch January 5, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants