fix: skip unmarshalling empty FinalizedBlocksHashes in cache path#2170
Merged
Conversation
When using smart router with static providers, FinalizedBlocksHashes
is empty since static providers don't participate in Lava's finalization
protocol. The cache code was attempting to unmarshal empty byte slices
which fails with 'expected {} for map'.
This fix adds a length check before attempting to unmarshal, gracefully
handling the case where FinalizedBlocksHashes is not populated.
NadavLevi
approved these changes
Jan 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using smart router with static providers, FinalizedBlocksHashes is empty since static providers don't participate in Lava's finalization protocol. The cache code was attempting to unmarshal empty byte slices which fails with 'expected {} for map'.
This fix adds a length check before attempting to unmarshal, gracefully handling the case where FinalizedBlocksHashes is not populated.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...