Skip to content

fix: clean up dead gRPC connections to prevent accumulation#2168

Merged
nimrod-teich merged 1 commit into
mainfrom
fix/grpc_client_is_closing
Dec 31, 2025
Merged

fix: clean up dead gRPC connections to prevent accumulation#2168
nimrod-teich merged 1 commit into
mainfrom
fix/grpc_client_is_closing

Conversation

@NadavLevi

Copy link
Copy Markdown
Contributor

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@github-actions

github-actions Bot commented Dec 31, 2025

Copy link
Copy Markdown

Test Results

    7 files  ±0    131 suites  ±0   35m 34s ⏱️ + 1m 26s
3 220 tests +1  3 219 ✅ +1  1 💤 ±0  0 ❌ ±0 
3 300 runs  +1  3 299 ✅ +1  1 💤 ±0  0 ❌ ±0 

Results for commit 4043b71. ± Comparison against base commit 9184964.

♻️ This comment has been updated with latest results.

avitenzer
avitenzer previously approved these changes Dec 31, 2025
@NadavLevi NadavLevi force-pushed the fix/grpc_client_is_closing branch from 451fc04 to 03b7b1d Compare December 31, 2025 14:28
@nimrod-teich nimrod-teich merged commit 416364d into main Dec 31, 2025
30 checks passed
@nimrod-teich nimrod-teich deleted the fix/grpc_client_is_closing branch December 31, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants