fix: LavaFormatLog must always return error when called#2167
Merged
Conversation
The early return optimization in #2155 broke the contract that LavaFormat* functions always return an error. When log level was disabled and no original error was passed, it returned nil instead of an error. This caused issues like: return nil, utils.LavaFormatTrace("error message") to return (nil, nil) instead of (nil, error), leading to nil pointer panics in code that relied on the error return. Changes: - utils/lavalog.go: Return fmt.Errorf based on description when log level disabled and no original error - protocol/parser/parser.go: Add defensive nil checks as safety net
a7ad6b4 to
15d53a6
Compare
NadavLevi
approved these changes
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The early return optimization in #2155 broke the contract that LavaFormat*
functions always return an error. When log level was disabled and no original
error was passed, it returned nil instead of an error.
This caused issues like:
return nil, utils.LavaFormatTrace("error message")
to return (nil, nil) instead of (nil, error), leading to nil pointer panics
in code that relied on the error return.
Changes:
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...