Skip to content

fix(resource_limiter): batches are going to heavy bucket instead of n…#2140

Merged
nimrod-teich merged 1 commit into
mainfrom
batch_to_heavy
Dec 10, 2025
Merged

fix(resource_limiter): batches are going to heavy bucket instead of n…#2140
nimrod-teich merged 1 commit into
mainfrom
batch_to_heavy

Conversation

@NadavLevi

@NadavLevi NadavLevi commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

…ormal one

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@NadavLevi NadavLevi requested a review from avitenzer December 10, 2025 13:59
@github-actions

github-actions Bot commented Dec 10, 2025

Copy link
Copy Markdown

Test Results

    5 files   -   2    128 suites   - 3   23m 9s ⏱️ - 10m 48s
2 956 tests  - 192  2 949 ✅  - 198  1 💤 ±0  0 ❌ ±0  6 🔥 +6 
3 036 runs   - 192  3 029 ✅  - 198  1 💤 ±0  0 ❌ ±0  6 🔥 +6 

For more details on these errors, see this check.

Results for commit adc3854. ± Comparison against base commit 4ee4fa7.

This pull request removes 195 and adds 3 tests. Note that renamed tests count towards both. 
github.com/lavanet/lava/v5/ecosystem/cache ‑ TestCacheExpirationMultiplier
github.com/lavanet/lava/v5/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_1
github.com/lavanet/lava/v5/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_1.2
github.com/lavanet/lava/v5/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_2
github.com/lavanet/lava/v5/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_2.5
github.com/lavanet/lava/v5/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_200
github.com/lavanet/lava/v5/ecosystem/cache ‑ TestCacheFailSetWithInvalidRequestBlock
github.com/lavanet/lava/v5/ecosystem/cache ‑ TestCacheFailSetWithInvalidRequestBlock/Finalized_After_delay_No_Hash
github.com/lavanet/lava/v5/ecosystem/cache ‑ TestCacheFailSetWithInvalidRequestBlock/Finalized_After_delay_No_Hash#01
github.com/lavanet/lava/v5/ecosystem/cache ‑ TestCacheFailSetWithInvalidRequestBlock/Finalized_After_delay_With_Hash
…

github.com/lavanet/lava/v5/protocol/rpcprovider ‑ TestResourceLimiter_SelectBucket_CUPriority/Batch_method_with_ampersands_uses_heavy_bucket
github.com/lavanet/lava/v5/protocol/rpcprovider ‑ TestResourceLimiter_SelectBucket_CUPriority/Batch_method_with_high_CU_uses_heavy_bucket
github.com/lavanet/lava/v5/protocol/rpcprovider ‑ TestResourceLimiter_SelectBucket_CUPriority/Single_ampersand_in_method_name_treated_as_batch

@nimrod-teich nimrod-teich merged commit f4a2860 into main Dec 10, 2025
16 of 19 checks passed
@nimrod-teich nimrod-teich deleted the batch_to_heavy branch December 10, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avitenzer avitenzer avitenzer approved these changes

Assignees

No one assigned

Labels

C:protocol size/S Team:Protocol

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NadavLevi @avitenzer @nimrod-teich