Skip to content

feat: Remove referer functionality#2137

Merged
nimrod-teich merged 3 commits into
mainfrom
referer-removal
Jan 19, 2026
Merged

feat: Remove referer functionality#2137
nimrod-teich merged 3 commits into
mainfrom
referer-removal

Conversation

@nimrod-teich

@nimrod-teich nimrod-teich commented Dec 7, 2025

Copy link
Copy Markdown
Contributor
  • Remove refererBackendAddressFlagName and refererMarkerFlagName flags
  • Remove RefererData struct and all related code
  • Remove referer route registrations from REST, JSON-RPC, and Tendermint RPC
  • Delete ConsumerReferrerClient implementation and tests
  • Update all function signatures to remove refererData parameters
  • Clean up unused imports and variables

Related to PR #1210

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Note

Eliminates referer support throughout the consumer stack and simplifies listener/manager APIs.

  • Removes RefererData and all referer logic (headers extraction, websocket/local storage, SendReferer calls) from chainlib (JSON-RPC, Tendermint RPC, REST, gRPC) and websocket managers
  • Deletes protocol/metrics/consumer_referrer_client.* and related tests
  • Drops CLI flags referer-be-address and referer-marker; cleans config example by removing commented referer-be-address
  • Updates constructors and function signatures to exclude referer params (e.g., NewChainListener, NewJrpcChainListener, NewTendermintRpcChainListener, NewRestChainListener, NewGrpcChainListener, ConsumerWSSubscriptionManager, ServeRPCRequests) and adjusts all callers
  • Removes referer-specific routes from HTTP servers and associated middleware
  • Fixes imports and updates unit/integration tests to the new signatures

Written by Cursor Bugbot for commit f774ba1. This will update automatically on new commits. Configure here.

@github-actions

github-actions Bot commented Dec 7, 2025

Copy link
Copy Markdown

Test Results

    7 files  ±0    128 suites  ±0   34m 27s ⏱️ + 1m 43s
3 183 tests  - 4  3 182 ✅  - 4  1 💤 ±0  0 ❌ ±0 
3 266 runs   - 4  3 265 ✅  - 4  1 💤 ±0  0 ❌ ±0 

Results for commit f774ba1. ± Comparison against base commit b6477b2.

This pull request removes 4 tests.
github.com/lavanet/lava/v5/protocol/metrics ‑ TestReferrerClientFlows
github.com/lavanet/lava/v5/protocol/metrics ‑ TestReferrerClientFlows/one-shot
github.com/lavanet/lava/v5/protocol/metrics ‑ TestReferrerClientNull
github.com/lavanet/lava/v5/protocol/metrics ‑ TestReferrerClientNull/null

♻️ This comment has been updated with latest results.

Comment thread protocol/chainlib/consumer_websocket_manager.go
@nimrod-teich nimrod-teich force-pushed the referer-removal branch 2 times, most recently from 45bc5dc to e7c6fe9 Compare December 11, 2025 12:29

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on January 23

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Comment thread .github/workflows/lava.yml Outdated
@nimrod-teich nimrod-teich force-pushed the referer-removal branch 3 times, most recently from 83092d5 to 658670c Compare December 30, 2025 15:28
- Remove refererBackendAddressFlagName and refererMarkerFlagName flags
- Remove RefererData struct and all related code
- Remove referer route registrations from REST, JSON-RPC, and Tendermint RPC
- Delete ConsumerReferrerClient implementation and tests
- Update all function signatures to remove refererData parameters
- Clean up unused imports and variables

Related to PR #1210
- Remove refererMatchString field from ConsumerWebsocketManager struct
- Remove RefererMatchString field from ConsumerWebsocketManagerOptions struct
- Remove RefererMatchString parameter from jsonRPC and tendermintRPC websocket initialization
- Update NewConsumerWSSubscriptionManager calls in tests to remove refererData parameter
- Update ServeRPCRequests calls in tests to remove refererData parameter
- Fix code formatting with gofmt and gofumpt
@nimrod-teich nimrod-teich merged commit 3b04cb1 into main Jan 19, 2026
32 checks passed
@nimrod-teich nimrod-teich deleted the referer-removal branch January 19, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants