Skip to content

fix(consumer/smartrouter): set a MaxComputeUnits for testing, to avoi…#2131

Merged
nimrod-teich merged 3 commits into
mainfrom
fix/failing_tests
Dec 4, 2025
Merged

fix(consumer/smartrouter): set a MaxComputeUnits for testing, to avoi…#2131
nimrod-teich merged 3 commits into
mainfrom
fix/failing_tests

Conversation

@NadavLevi

Copy link
Copy Markdown
Contributor

…d warnings that failed the rpcsmartrouter tests

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@github-actions

github-actions Bot commented Dec 4, 2025

Copy link
Copy Markdown

Test Results

    7 files  +  1    130 suites  +6   20m 16s ⏱️ - 5m 35s
3 092 tests +161  3 090 ✅ +162  1 💤 ±0  0 ❌  - 2  1 🔥 +1 
3 172 runs  +241  3 170 ✅ +242  1 💤 ±0  0 ❌  - 2  1 🔥 +1 

For more details on these errors, see this check.

Results for commit 3b65471. ± Comparison against base commit ddac432.

♻️ This comment has been updated with latest results.

@pull-request-size pull-request-size Bot added size/M and removed size/XS labels Dec 4, 2025
@pull-request-size pull-request-size Bot added size/L and removed size/M labels Dec 4, 2025
@NadavLevi NadavLevi force-pushed the fix/failing_tests branch 2 times, most recently from d39d314 to fa7b262 Compare December 4, 2025 12:02
@nimrod-teich nimrod-teich merged commit fcfc3c7 into main Dec 4, 2025
63 of 67 checks passed
@nimrod-teich nimrod-teich deleted the fix/failing_tests branch December 4, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants