Skip to content

fix(rpcprovider): add nil check to avoid nil dereferences issues#2127

Merged
nimrod-teich merged 1 commit into
mainfrom
fix/bron_eth_problems
Dec 4, 2025
Merged

fix(rpcprovider): add nil check to avoid nil dereferences issues#2127
nimrod-teich merged 1 commit into
mainfrom
fix/bron_eth_problems

Conversation

@NadavLevi

@NadavLevi NadavLevi commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@github-actions

github-actions Bot commented Dec 3, 2025 •
edited
Loading

Copy link
Copy Markdown

Test Results

2 900 tests   - 31   2 893 ✅  - 35   19m 35s ⏱️ - 6m 16s
  123 suites  -  1       1 💤 ± 0 
    5 files    -  1       0 ❌  -  2   6 🔥 +6 

For more details on these errors, see this check.

Results for commit f6fed36. ± Comparison against base commit ddac432.

This pull request removes 31 tests. 
github.com/lavanet/lava/v5/protocol/chainlib ‑ TestAddAttributeToError/Valid_conversion
github.com/lavanet/lava/v5/protocol/chainlib ‑ TestConvertToJsonError/valid_json
github.com/lavanet/lava/v5/protocol/chainlib ‑ TestMatchSpecApiByName/test1
github.com/lavanet/lava/v5/protocol/chainlib ‑ TestMatchSpecApiByName/test2
github.com/lavanet/lava/v5/protocol/chainlib ‑ TestMatchSpecApiByName/test3
github.com/lavanet/lava/v5/protocol/chainlib ‑ TestParsingRequestedBlocksHeadersRest
github.com/lavanet/lava/v5/protocol/chainlib ‑ TestParsingRequestedBlocksHeadersRest/no_metadata
github.com/lavanet/lava/v5/protocol/chainlib ‑ TestParsingRequestedBlocksHeadersRest/with-metadata
github.com/lavanet/lava/v5/protocol/chainlib ‑ TestRegexParsing
github.com/lavanet/lava/v5/protocol/chainlib ‑ TestRestChainParser_NilGuard
…

♻️ This comment has been updated with latest results.

avitenzer
avitenzer reviewed Dec 4, 2025
View reviewed changes
Comment thread protocol/rpcprovider/rpcprovider_server.go
@NadavLevi NadavLevi force-pushed the fix/bron_eth_problems branch from 2646dbe to 2015e6b Compare December 4, 2025 11:00
@pull-request-size pull-request-size Bot added size/XL and removed size/S labels Dec 4, 2025
@NadavLevi NadavLevi force-pushed the fix/bron_eth_problems branch from 2015e6b to 3f84427 Compare December 4, 2025 11:00
@NadavLevi NadavLevi force-pushed the fix/bron_eth_problems branch from 3f84427 to f6fed36 Compare December 4, 2025 11:01
@pull-request-size pull-request-size Bot added size/S and removed size/XL labels Dec 4, 2025
@nimrod-teich nimrod-teich merged commit 9b73851 into main Dec 4, 2025
21 of 27 checks passed
@nimrod-teich nimrod-teich deleted the fix/bron_eth_problems branch December 4, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nimrod-teich nimrod-teich nimrod-teich approved these changes

@avitenzer avitenzer avitenzer approved these changes

Assignees

No one assigned

Labels

C:protocol size/S Team:Protocol

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NadavLevi @nimrod-teich @avitenzer