Skip to content

fix: fix sessions leak issue#2120

Merged
nimrod-teich merged 4 commits into
mainfrom
fix_sessions_issue
Nov 30, 2025
Merged

fix: fix sessions leak issue#2120
nimrod-teich merged 4 commits into
mainfrom
fix_sessions_issue

Conversation

@avitenzer

Copy link
Copy Markdown
Collaborator

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

…ion accumulation

- Replaced old provider and backup session handling with fresh session creation to avoid accumulation in the Sessions map.
- Introduced logic to create new ConsumerSessionsWithProvider objects for both provider and backup sessions, ensuring they are initialized with the latest epoch.
- Updated session manager to utilize fresh sessions, enhancing stability and preventing "No pairings available" errors during high-load scenarios.
@github-actions

github-actions Bot commented Nov 30, 2025

Copy link
Copy Markdown

Test Results

3 090 tests  +1   3 089 ✅ +1   32m 24s ⏱️ - 2m 47s
  126 suites ±0       1 💤 ±0 
    7 files   ±0       0 ❌ ±0 

Results for commit ab16273. ± Comparison against base commit 1087ad5.

♻️ This comment has been updated with latest results.

@pull-request-size pull-request-size Bot added size/L and removed size/M labels Nov 30, 2025
@nimrod-teich nimrod-teich merged commit 419be7f into main Nov 30, 2025
30 checks passed
@nimrod-teich nimrod-teich deleted the fix_sessions_issue branch November 30, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants