feat: Protocol error prometheus metric#2119
Merged
Merged
Conversation
… to RPCConsumerLogs for tracking protocol error recovery
Test Results3 092 tests +3 3 091 ✅ +3 23m 28s ⏱️ - 11m 43s Results for commit c7a9966. ± Comparison against base commit 1087ad5. This pull request removes 1 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
nimrod-teich
requested changes
Nov 27, 2025
| @@ -266,6 +267,11 @@ func NewConsumerMetricsManager(options ConsumerMetricsManagerOptions) *ConsumerM | |||
Contributor
There was a problem hiding this comment.
you should have the same for protocol errors:
lava_consumer_total_protocol_errors_recovery_attempts
Tomelia1999
commented
Nov 30, 2025
| @@ -266,6 +267,11 @@ func NewConsumerMetricsManager(options ConsumerMetricsManagerOptions) *ConsumerM | |||
| Help: "The total number of retries sent due to retry mechanism", | |||
| }, []string{"spec", "apiInterface"}) | |||
Contributor
Author
There was a problem hiding this comment.
should add the attempts metric for "protocol errors", same ass I did for lava_consumer_total_protocol_errors_recovered_successfully
Follow the behavior of lava_consumer_total_node_errors_recovery_attempts
nimrod-teich
approved these changes
Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...