fix: fix e2e issues#2114
Merged
Merged
Conversation
avitenzer
reviewed
Nov 27, 2025
Collaborator
There was a problem hiding this comment.
Consider adding in line 334
deadline := time.Now().Add(timeout)
and replace 336 and 354 with
for time.Now().Before(deadline) {
21eb5df to
190dd03
Compare
avitenzer
previously approved these changes
Dec 7, 2025
6cd6ee3 to
894152d
Compare
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Enhanced checkLava() to wait for validators to be queryable via the staking module before running init_e2e.sh, preventing operator_address() from timing out in CI.
Wait for proposal submission transaction to be included in a block before voting. This prevents account sequence mismatch errors when transactions are broadcast in sync mode. Fixes panic in TestLavaProtocolPayment: 'account sequence mismatch'
- Fixed resource leak in by using cancellable context for connector loop - Patched to gracefully handle websocket closure errors - Resolved failure by checking all call options for trailer - Removed temporary debug logs and cleaned up test helpers
16a0d56 to
edba134
Compare
- Fix deadlock in ClientSubscription.run() by making error reporting non-blocking - Fix panic in genericWebSocketHandler when connection is closed by client
3c84480 to
64b3567
Compare
avitenzer
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Note
Adds panic recovery and session cleanup to provider Relay, and strengthens E2E framework/scripts with expected process exits, validator readiness checks, and improved logging.
RPCProviderServer.Relay: add panic recovery with stack logging; ensure session unlock viaOnSessionFailureon panic/unsupported methods; integrate resource limiter rejection path to properly unlock/rollback sessions; switch to named return values.testutil/e2e):stopLava.checkLavabefore proceeding.saveLogs(); improve error aggregation/printing.ethtypesaliases; minor timing and reliability tweaks.scripts/test):wait_next_block; add waits after votes; validate operator address presence; add startup logs.Written by Cursor Bugbot for commit 348ac1a. This will update automatically on new commits. Configure here.