fix: critical epoch transition gap#2113
Merged
Merged
Conversation
avitenzer
reviewed
Nov 25, 2025
Collaborator
There was a problem hiding this comment.
Consider adding cleanup of previousEpochBlockedProviders at the end of the checkAndUnblockHealthyReBlockedProviders function
defer func() {
csm.previousEpochBlockedProviders = make(map[string]struct{})
}()
Also you should check that the current epoch is still valid i.e.
if epoch != csm.atomicReadCurrentEpoch() {
utils.LavaFormatDebug("Skipping re-blocked provider check due to epoch change",
utils.Attribute{Key: "requestedEpoch", Value: epoch},
utils.Attribute{Key: "currentEpoch", Value: csm.atomicReadCurrentEpoch()},
)
return
}
Fixes race condition at epoch boundaries where blocked providers got clean slate and users hit them with long timeouts before probes could re-block. Solution: Save and restore blocking history, immediately unblock if probe succeeds by checking reportedProviders state (no duplicate probing)
- Refactor validateAndReturnBlockedProviderToValidAddressesList to separate locking logic, resolving a recursive lock deadlock in checkAndUnblockHealthyReBlockedProviders. - Inject Unique Identifier (GUID) into context in checkAndUnblockHealthyReBlockedProviders to prevent probeProvider from failing during comprehensive probes.
ae7f5d2 to
f79c584
Compare
…kedProviders - Add epoch validity check to prevent processing stale data during rapid epoch transitions - Add cleanup of previousEpochBlockedProviders after processing to free memory - Prevents race condition where probe completes after epoch has already advanced - Critical for test reliability with 10s epoch timers
avitenzer
approved these changes
Dec 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...