fix: treat nodeErrors as valid response#2110
Merged
Merged
Conversation
Test Results 6 files - 1 130 suites - 1 24m 10s ⏱️ - 9m 47s Results for commit ff129aa. ± Comparison against base commit 4ee4fa7. This pull request removes 1 and adds 24 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
… responses are not equale -> do not met quorum
Tomelia1999
commented
Nov 25, 2025
| // When quorum is enabled, we need to ensure we have enough successful responses | ||
| // to actually meet quorum requirements, not just enough total attempts | ||
| if rp.quorumParams.Enabled() && successResultsCount < rp.quorumParams.Min { | ||
| if rp.quorumParams.Enabled() && successResultsCount < rp.quorumParams.Min && nodeErrorCount < rp.quorumParams.Min { |
Contributor
Author
There was a problem hiding this comment.
needs to be reverted if we decide to not add support for nodeErrors in the quorum feature
…into nodeErrors-in-quorum
…into nodeErrors-in-quorum
…(stateful) selection
avitenzer
reviewed
Dec 10, 2025
Collaborator
There was a problem hiding this comment.
In Line 639 we should add logging i.e.
if nodeErrorErr == nil {
utils.LavaFormatInfo("Using node error quorum as fallback (success responses didn't match)",
utils.LogAttr("successCount", successResultsCount),
utils.LogAttr("nodeErrorCount", nodeErrorCount))
return nodeErrorResult, nil
}
avitenzer
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...