Skip to content

fix(consumer): use hash instead of string in qourumMap#2109

Merged
nimrod-teich merged 1 commit into
mainfrom
fix/hash_instead_of_string
Nov 24, 2025
Merged

fix(consumer): use hash instead of string in qourumMap#2109
nimrod-teich merged 1 commit into
mainfrom
fix/hash_instead_of_string

Conversation

@NadavLevi

Copy link
Copy Markdown
Contributor

Description

Closes: #XXXX

Use hash instead of strings as the keys in the quorumMap;
This improves memory usage as we are saving a constant amount of memory per key.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@github-actions

github-actions Bot commented Nov 23, 2025

Copy link
Copy Markdown

Test Results

3 067 tests  +19   3 066 ✅ +19   32m 43s ⏱️ + 9m 24s
  126 suites + 1       1 💤 ± 0 
    7 files   + 1       0 ❌ ± 0 

Results for commit ad54afd. ± Comparison against base commit bfc3ac4.

♻️ This comment has been updated with latest results.

@NadavLevi NadavLevi force-pushed the fix/hash_instead_of_string branch from d5e8289 to fb2bcf8 Compare November 24, 2025 10:40
@pull-request-size pull-request-size Bot added size/L and removed size/M labels Nov 24, 2025
@NadavLevi NadavLevi requested a review from avitenzer November 24, 2025 10:41
@NadavLevi NadavLevi force-pushed the fix/hash_instead_of_string branch from fb2bcf8 to b5cd6da Compare November 24, 2025 12:25
Comment thread protocol/relaycore/relay_processor.go
@NadavLevi NadavLevi force-pushed the fix/hash_instead_of_string branch from 2ad2a31 to ad54afd Compare November 24, 2025 14:58
@NadavLevi NadavLevi requested a review from avitenzer November 24, 2025 14:59
@nimrod-teich nimrod-teich merged commit 048cf05 into main Nov 24, 2025
30 checks passed
@nimrod-teich nimrod-teich deleted the fix/hash_instead_of_string branch November 24, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants