fix(bsc spec): update BSC average_block_time and block lag#2100
Merged
Conversation
Contributor
|
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Bug: Standardize API Collections Across Specifications
The BSCT spec's api_collections entry is missing the "extensions": [] field that is present in the BSC spec's corresponding entry. Both specs should have consistent structure for their api_collections configuration.
specs/testnet-2/specs/bsc.json#L88-L89
lava/specs/testnet-2/specs/bsc.json
Lines 88 to 89 in 0bc98ec
a81a1b7 to
c4b01cf
Compare
c4b01cf to
d8ebe25
Compare
nimrod-teich
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Note
Update BSC and BSCT specs to set average_block_time to 750 (from 3000) and allowed_block_lag_for_qos_sync to 14 (from 4).
specs/testnet-2/specs/bsc.json):index: BSC):average_block_timeto750(was3000).allowed_block_lag_for_qos_syncto14(was4).index: BSCT):average_block_timeto750(was3000).allowed_block_lag_for_qos_syncto14(was4).Written by Cursor Bugbot for commit 0bc98ec. This will update automatically on new commits. Configure here.