fix: prevent consumer crash from nil pointer dereference in relay#2091
Merged
Conversation
…outines When all providers are blocked/unavailable, relay goroutines could crash with nil pointer dereference when accessing RelayPrivateData fields. This panic would crash the entire consumer process. Changes: - Add nil check before dereferencing RelayPrivateData pointer - Add panic recovery in sendRelayToProvider goroutines - Treat panics as provider failures instead of crashing consumer - Include stack traces in error logs for debugging
…rash Race condition occurred when multiple concurrent calls to sendRelayToProvider shared the same protocolMessage.RelayPrivateData() object. Goroutines from earlier calls would read corrupted data when newer calls modified SeenBlock or Extensions fields, resulting in nil pointer dereference in bytes.Join. Solution: Create deep copy of RelayPrivateData at function entry to ensure complete isolation between concurrent calls. Each goroutine now receives its own independent copy via parameter passing instead of closure capture. Changes: - Add deepCopyRelayPrivateData() helper to create independent copies - Snapshot RelayPrivateData at sendRelayToProvider entry point - Replace all protocolMessage.RelayPrivateData() accesses with local copy - Pass local copy as parameter to goroutines for proper isolation
50bac32 to
6b5f9e7
Compare
avitenzer
approved these changes
Nov 20, 2025
avitenzer
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When all providers are blocked/unavailable, relay goroutines could crash with nil pointer dereference when accessing RelayPrivateData fields. This panic would crash the entire consumer process.
Changes:
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...